PuTTY bug assert-fail-newsavelines

This is a mirror. Follow this link to find the primary PuTTY web site.

Home | FAQ | Feedback | Licence | Updates | Mirrors | Keys | Links | Team
Download: Stable · Snapshot | Docs | Changes | Wishlist

summary: Failed assertion: count234(term->scrollback) <= newsavelines
class: bug: This is clearly an actual problem we want fixed.
priority: medium: This should be fixed one day.
present-in: 0.55 0.58

We've had occasional reports of the failure of the following assertion:

terminal.c:559 (0.55), :454 (0.58)
count234(term->scrollback) <= newsavelines

Most of the reports we've had seem to also include a CPU-intensive delay at connection startup (possibly at other times too).

The only way we've found to reproduce this assertion failure is by configuring a negative number of lines in the scrollback. If the magnitude of the negative number is large, we see the delay at startup too.

On some platforms (including Windows), a very large positive scrollback setting can end up treated as a negative one, triggering this. This can happen for scrollback sizes of 231 (2147483648) or greater. (You'd probably run out of physical memory before filling up such a ridiculously large scrollback buffer!) So don't do that, then.

We should probably be robust against silly configurations like this.

(Possibly related, although we've no hard evidence for this: assert-line-not-null.)

If you want to comment on this web site, see the Feedback page.
Audit trail for this bug.
(last revision of this bug record was at 2017-04-28 16:52:45 +0100)