commit 64c1c8db6988a230d66f3b70e1d93dc6838c556b Author: Travis Reitter Date: Fri Jun 7 15:20:17 2013 -0700 Release version 0.9.2 configure.ac | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit f2e229d963bd6f10a8e9210688cc144e449e756c Author: Travis Reitter Date: Fri Jun 7 16:14:56 2013 -0700 Temporarily work around valadoc crasher with eds docs docs/Makefile.am | 137 ++++++++++++++++++++++++++++--------------------------- 1 file changed, 69 insertions(+), 68 deletions(-) commit 0b3481831b43b9bc8dd9133bfe6d78f1a0103fe0 Author: Travis Reitter Date: Fri Jun 7 15:31:22 2013 -0700 Temporarily work around valadoc crasher with Telepathy docs docs/Makefile.am | 135 ++++++++++++++++++++++++++++--------------------------- 1 file changed, 68 insertions(+), 67 deletions(-) commit db34229d48f33f9d936a892d4fe91989043e1bc6 Author: Travis Reitter Date: Fri Jun 7 15:19:08 2013 -0700 Cut excess line NEWS | 1 - 1 file changed, 1 deletion(-) commit f447a3f9c0c64a4256b274645e4ac604cca20f44 Author: Travis Reitter Date: Fri Jun 7 15:15:35 2013 -0700 Set release version of new API and update NEWS NEWS | 2 ++ backends/eds/lib/edsf-persona.vala | 4 ++-- folks/location-details.vala | 14 +++++++------- folks/persona-store.vala | 2 +- 4 files changed, 12 insertions(+), 10 deletions(-) commit 4bd87783b97955a2dce0f0ba3d4cbf96d3c2ab20 Author: Travis Reitter Date: Fri Jun 7 15:01:35 2013 -0700 Make Telepathy docs build defs stand-alone docs/Makefile.am | 49 ++++++++++++++++++++++++++++++------------------- 1 file changed, 30 insertions(+), 19 deletions(-) commit f2ac22ee276ef9b7ae3e8baed920cc5d991b78ef Author: Travis Reitter Date: Fri Jun 7 09:11:04 2013 -0700 Pass the --driver version to valadoc to minimize complications. This ensures that we're building the library with the same version of Vala that valadoc uses docs/Makefile.am | 1 + 1 file changed, 1 insertion(+) commit 1db949c7d168209f2f09ba017a72ecb12f4fe278 Author: Travis Reitter Date: Thu Jun 6 17:08:19 2013 -0700 Use correct @return instead of @returns (which breaks valadoc) backends/ofono/ofono-backend.vala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 93b4b88da85ca305a38b62fccc88046a8f807169 Author: Travis Reitter Date: Thu Jun 6 16:01:48 2013 -0700 Bump libebook requirement to un-break GIR bindings. E.BookClient.connect() had been annotated to return void so this should fix the issue. NEWS | 3 +++ configure.ac | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) commit f1e24400a254e9d3f14a9660379f01ed9dc793bc Author: Lionel Landwerlin Date: Mon May 13 21:22:02 2013 +0100 backends: eds: make the personna store backend more 'async' Bug: https://bugzilla.gnome.org/show_bug.cgi?id=700253 NEWS | 2 +- backends/eds/lib/edsf-persona-store.vala | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit a24ec72eecd68cda328cd93f8896e3c1d9952452 Author: Travis Reitter Date: Thu Apr 25 17:45:42 2013 -0700 Correctly check for existence of Zeitgeist. configure.ac | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 204c5394a7120b4ad6f4e90efb4d1b03daa08cf4 Author: Travis Reitter Date: Wed Apr 24 11:22:15 2013 -0700 Correct the terminology in Zeitgeist check failure configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d9ae3100a70f89ace7c6a853dfbc1ebd22d5802f Author: Maciej Piechotka Date: Sat Apr 20 13:32:19 2013 +0200 Remove autodependency on zeitgeist configure.ac | 31 ++++++++++++++++++++++++++++--- 1 file changed, 28 insertions(+), 3 deletions(-) commit 4ed7142e476edc26a51c37dc0294025b7a8705cb Author: Travis Reitter Date: Mon Apr 22 16:21:37 2013 -0700 build fix: include folks-generics in docs arguments docs/Makefile.am | 4 ++++ 1 file changed, 4 insertions(+) commit 43155c19ebbd06be0538926ca8eb4a33214395a7 Author: Simon McVittie Date: Thu Apr 11 11:53:41 2013 +0100 Add warnings (normally fatal) on use of archaic C features We don't want these even in C code generated by Vala, and certainly not in hand-written C code. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=697354 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall configure.ac | 30 ++++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) commit fa1a9b56a8f420b2672f668a558c42d17429f760 Author: Simon McVittie Date: Thu Apr 11 12:05:08 2013 +0100 Ensure that the C bits of TestCase are pre-declared in a header This lets us verify that their Vala and C ABIs are the same: if they are not, compilation will fail. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=697354 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/lib/Makefile.am | 1 + tests/lib/haze-remove-directory.c | 2 +- tests/lib/test-case-helper.c | 2 +- tests/lib/test-case.vala | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) commit 7a9c8133468c1f8eb7fbb0e68a6a7e061b9452fb Author: Simon McVittie Date: Fri Apr 12 12:20:43 2013 +0100 Declare internal function folks_persona_store_set_is_user_set_default() As explained in the comment, I can't find any better way to do this. Implicit declarations are Bad, so we should be making them into errors by default. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=697354 Reviewed-by: Philip Withnall [added a comment as requested -smcv] Signed-off-by: Simon McVittie backends/eds/lib/Makefile.am | 1 + folks/Makefile.am | 1 + folks/persona-store.vala | 4 ++++ folks/redeclare-internal-api.h | 46 ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 52 insertions(+) commit 43da0b634ede2fcbc17ce470f86158c2efe00ed3 Author: Simon McVittie Date: Mon Apr 8 11:50:38 2013 +0100 Include ERROR_CFLAGS everywhere we compile C code AM_CFLAGS was missing from a couple of foo_CFLAGS variables (it isn't "inherited" automatically), so add that too. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=697354 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall backends/eds/Makefile.am | 1 + backends/eds/lib/Makefile.am | 1 + backends/key-file/Makefile.am | 1 + backends/libsocialweb/Makefile.am | 1 + backends/libsocialweb/lib/Makefile.am | 2 ++ backends/ofono/Makefile.am | 1 + backends/telepathy/Makefile.am | 1 + backends/telepathy/lib/Makefile.am | 1 + backends/tracker/Makefile.am | 1 + backends/tracker/lib/Makefile.am | 1 + folks/Makefile.am | 1 + tests/eds/Makefile.am | 4 ++++ tests/folks/Makefile.am | 4 ++++ tests/key-file/Makefile.am | 4 ++++ tests/lib/Makefile.am | 1 + tests/lib/eds/Makefile.am | 2 ++ tests/lib/key-file/Makefile.am | 2 ++ tests/lib/libsocialweb/Makefile.am | 2 ++ tests/lib/telepathy/Makefile.am | 2 ++ tests/lib/telepathy/contactlist/Makefile.am | 2 ++ tests/lib/tracker/Makefile.am | 2 ++ tests/libsocialweb/Makefile.am | 4 ++++ tests/telepathy/Makefile.am | 4 ++++ tests/tracker/Makefile.am | 4 ++++ tools/Makefile.am | 1 + tools/inspect/Makefile.am | 1 + 26 files changed, 51 insertions(+) commit f5271892dac5137a824781f75ea03ee8a8df53dc Author: Simon McVittie Date: Mon Apr 8 11:43:25 2013 +0100 Re-brand ERROR_CFLAGS to C_ERROR_CFLAGS These are flags that we only use when compiling hand-written C code, mostly originating from telepathy-glib. We can't be that strict with the C code generated by Vala, because it's full of questionable things (which the Vala compiler verifies are OK, but the C compiler still warns about). Bug: https://bugzilla.gnome.org/show_bug.cgi?id=697354 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall backends/telepathy/lib/Makefile.am | 2 +- configure.ac | 22 ++++++++++++++-------- tests/lib/telepathy/contactlist/Makefile.am | 2 +- 3 files changed, 16 insertions(+), 10 deletions(-) commit c6c0635599b8540cb7f9395e95dd533bf866bf90 Author: Simon McVittie Date: Thu Apr 11 11:03:26 2013 +0100 TpfPersonaStore: make _supported_fields, _supported_fields_ro private Making them "internal" means we end up #include'ing small-set.h, which we don't install, so nothing can be built against the installed libfolks-telepathy. Nothing outside this file uses those members directly anyway. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=697542 Signed-off-by: Simon McVittie backends/telepathy/lib/tpf-persona-store.vala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 2d6fc26d8d7e3c8fd5b6d5485fadfe777ab7b601 Author: Wylmer Wang Date: Sat Apr 6 16:37:15 2013 +0800 update Simplified Chinese (zh_CN) translation po/zh_CN.po | 587 +++++++++++++++++++++++++++--------------------------------- 1 file changed, 267 insertions(+), 320 deletions(-) commit f18d26283c594efdcfee6cbc8b09855f0d65b4ad Author: Simon McVittie Date: Thu Apr 4 18:30:18 2013 +0100 Declare folks_small_set_copy properly Bug: https://bugzilla.gnome.org/show_bug.cgi?id=687161 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall folks/small-set.h | 8 ++++++++ 1 file changed, 8 insertions(+) commit 13220546e01844d7b879dd11eb82a0254ab0108d Author: Simon McVittie Date: Fri Apr 5 14:06:09 2013 +0100 tests: clear out various D-Bus-related variables The actual terminal in gnome-terminal 3.8 is an activatable service, so it has DBUS_STARTER_ADDRESS in its environment. telepathy-glib prefers DBUS_STARTER_ADDRESS over DBUS_SESSION_BUS_ADDRESS, but GTestDBus doesn't clear or set the former, only the latter; so we end up trying to use the real bus when run under a recent gnome-terminal. See also . Bug: https://bugzilla.gnome.org/show_bug.cgi?id=697261 Reviewed-by: Philip Withnall [added FIXME comment about #697348] Signed-off-by: Simon McVittie tests/lib/test-case.vala | 11 +++++++++++ tests/tools/dbus-session.sh | 5 +++++ 2 files changed, 16 insertions(+) commit bfab3ee28c15a4e3ed6d7a87a113b472afebd495 Author: Simon McVittie Date: Thu Apr 4 15:39:42 2013 +0100 all tests: disable non-local GIO VFS backends, such as gvfs Bug: https://bugzilla.gnome.org/show_bug.cgi?id=697261 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/lib/test-case.vala | 4 ++++ 1 file changed, 4 insertions(+) commit 53337413fc236b5d3527378face31ca8d9af39cb Author: Simon McVittie Date: Thu Apr 4 15:35:12 2013 +0100 tracker tests: do not request starting all Tracker services We don't care about tracker-miner-fs etc. for these tests; all we want to do is stop any running Tracker stuff. D-Bus service activation will ensure that we get the necessary services when they're needed, without starting the unnecessary ones. (This fixes the Tracker tests on a system without tracker-miner-fs.) Bug: https://bugzilla.gnome.org/show_bug.cgi?id=697261 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/tools/tracker.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit eebdc677e00a0114ebcf90cf8546998367f6fa96 Author: Simon McVittie Date: Wed Apr 3 18:12:23 2013 +0100 Use SmallSet.copy() where it makes sense It isn't more than fractionally faster in tests/eds/perf, but might help. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=687161 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall backends/eds/lib/edsf-persona.vala | 21 ++++++--------------- folks/anti-linkable.vala | 6 ++---- folks/individual-aggregator.vala | 15 ++++----------- 3 files changed, 12 insertions(+), 30 deletions(-) commit 06f06a10a754b28b8ede2ec840cbadbc8afb7733 Author: Simon McVittie Date: Thu Mar 28 14:46:55 2013 +0000 Add fast-path iteration for SmallSet Bug: https://bugzilla.gnome.org/show_bug.cgi?id=687161 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall configure.ac | 2 ++ folks/folks-generics.vapi | 5 +++++ folks/small-set-internal.h | 13 +++++++++++++ tests/folks/small-set.vala | 37 +++++++++++++++++++++++++++++++++++++ 4 files changed, 57 insertions(+) commit ab22ced5b97ef63ad206bdd6e3a9270969fb6157 Author: Simon McVittie Date: Thu Apr 4 13:00:53 2013 +0100 folks, backends: use "small sets" instead of hash sets most of the time Notable exceptions are: * sets of personas that are, or might be, the entire set from a backend (possible future refinement: use a SmallSet if there aren't many) * sets of potentially many Individuals (likewise) * the object cache (potentially pretty large) * debug stuff (not relevant for performance) * the set of IM addresses being matched (we want to keep this O(1), but it should be a GHashTable) This speeds up tests/eds/perf by around 5%. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=687161 Reviewed-by: Philip Withnall [squashed in responses to review -smcv] Signed-off-by: Simon McVittie backends/eds/lib/Makefile.am | 1 + backends/eds/lib/edsf-persona-store.vala | 6 +- backends/eds/lib/edsf-persona.vala | 76 +++++++++++----------- backends/key-file/Makefile.am | 1 + backends/key-file/kf-persona-store.vala | 4 +- backends/key-file/kf-persona.vala | 6 +- backends/libsocialweb/lib/Makefile.am | 1 + backends/libsocialweb/lib/swf-persona.vala | 4 +- backends/ofono/Makefile.am | 1 + backends/ofono/ofono-persona.vala | 8 +-- backends/telepathy/lib/Makefile.am | 1 + .../telepathy/lib/tpf-persona-store-cache.vala | 8 +-- backends/telepathy/lib/tpf-persona-store.vala | 22 +++---- backends/telepathy/lib/tpf-persona.vala | 26 ++++---- backends/tracker/lib/Makefile.am | 1 + backends/tracker/lib/trf-persona-store.vala | 35 +++++----- backends/tracker/lib/trf-persona.vala | 34 +++++----- folks/Makefile.am | 1 + folks/anti-linkable.vala | 4 +- folks/backend-store.vala | 8 +-- folks/individual-aggregator.vala | 32 ++++----- folks/individual.vala | 63 +++++++++--------- folks/potential-match.vala | 3 +- 23 files changed, 178 insertions(+), 168 deletions(-) commit 87422afd3b6341703f3f4d8718ac5cec8374969a Author: Simon McVittie Date: Thu Apr 4 12:58:50 2013 +0100 Folks.SmallSet: add and test Bug: https://bugzilla.gnome.org/show_bug.cgi?id=687161 Reviewed-by: Philip Withnall [squashed in responses to review -smcv] Signed-off-by: Simon McVittie folks/Makefile.am | 6 + folks/folks-generics.vapi | 45 +++ folks/small-set-internal.h | 85 ++++ folks/small-set.c | 954 +++++++++++++++++++++++++++++++++++++++++++++ folks/small-set.h | 73 ++++ tests/folks/Makefile.am | 7 + tests/folks/small-set.vala | 421 ++++++++++++++++++++ 7 files changed, 1591 insertions(+) commit 07747b757cb4a372f30d540143046765ceb2192c Author: Simon McVittie Date: Wed Apr 3 18:49:23 2013 +0100 contactlist: copy .deps to the same place as .vapi if necessary valac specifically expects to find them in the same place: it's not enough to have them both in the search path. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=697188 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/lib/telepathy/contactlist/Makefile.am | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit fde2cc3e66b782638d702cec6059eede882820c9 Author: Simon McVittie Date: Wed Apr 3 16:52:38 2013 +0100 Compile tp-lowlevel.vapi before libfolks_telepathy_la_vala.stamp The make rules generated by Automake are all done in terms of a "stamp" file in the $(srcdir), so if we want to give it more dependencies, we need to do the same. This fixes a clean out-of-tree build. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=697188 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall backends/telepathy/lib/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fcfd16cbc3148f15e53956a8fece6e67a2023652 Author: Simon McVittie Date: Tue Apr 2 19:00:02 2013 +0100 Do not explicitly link libfolks-internal.la into things libfolks.la embeds a copy of libfolks-internal.la, so every public (or internal) symbol in libfolks-internal.la is available in libfolks.la, even if linked with -Wl,--no-copy-dt-needed-entries. If libfolks-internal.la defines a GObject type, then linking two copies of it is actively harmful, because they can't both be registered with the type system. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=687161 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall backends/eds/Makefile.am | 1 - backends/eds/lib/Makefile.am | 1 - backends/key-file/Makefile.am | 1 - backends/libsocialweb/Makefile.am | 1 - backends/ofono/Makefile.am | 1 - backends/telepathy/Makefile.am | 1 - backends/telepathy/lib/Makefile.am | 1 - backends/tracker/Makefile.am | 1 - backends/tracker/lib/Makefile.am | 1 - 9 files changed, 9 deletions(-) commit e5b075082d75d83829b23e99f60c75482ddd7784 Author: Simon McVittie Date: Tue Apr 2 18:30:13 2013 +0100 backends: when adding a persona by details, do not assume HashSet All we need is a Set, so we shouldn't need to cast this strictly. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=687161 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall backends/eds/lib/edsf-persona-store.vala | 2 +- backends/tracker/lib/trf-persona-store.vala | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) commit 5226ce9395749259cdc3bab8a94c0244ae3315ac Author: Simon McVittie Date: Tue Apr 2 17:53:36 2013 +0100 By default, do debug output iff at least one debug domain is enabled Previously, debug output (and expensive checks that are enabled alongside debug output) was always enabled unless explicitly disabled, but Philip noted that this was not intentional. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=687161 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall folks/debug.vala | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit c438d6d00ad5e513d09315a8cbe285cd1436794d Author: Simon McVittie Date: Thu Mar 28 12:17:38 2013 +0000 IndividualAggregator: assert and assume that _link_map[key][i] != null The link map's type is non-nullable, and when we add individuals to the link map we do so through a function that does not allow a null argument, so we don't need to sprinkle (!) casts around. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=687161 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall folks/individual-aggregator.vala | 31 ++++++++++++++----------------- 1 file changed, 14 insertions(+), 17 deletions(-) commit 2ec38a5d15bf0dc33908ae7302c6f65b9b52b6f4 Author: Simon McVittie Date: Wed Mar 27 16:20:55 2013 +0000 IndividualAggregator: use a GHashTable for the link map The link map is a hot path, particularly when matching multiple copies of the same contact. Speed this up. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=687161 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall folks/individual-aggregator.vala | 172 +++++++++++++++++++++++++-------------- 1 file changed, 111 insertions(+), 61 deletions(-) commit 00aa53c96e22715885aa9be2685dd10f39e36456 Author: Inaki Larranaga Murgoitio Date: Tue Apr 2 10:40:38 2013 +0200 Added Basque language\nAdded 'eu' (Basque) to LINGUAS po/LINGUAS | 1 + po/eu.po | 718 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 719 insertions(+) commit 62fe0c462b4662bc72e8485fb1d6ea09617a2410 Author: Simon McVittie Date: Tue Mar 26 19:13:46 2013 +0000 Edsf.PersonaStore: defer contacts-complete like contacts-added Otherwise, we signal quiescence while not actually quiescent: our initial batch of contacts could still be coming in. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=696659 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall backends/eds/lib/edsf-persona-store.vala | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) commit 1e2fb274c1fa220dfca43f97dd6f5c1ca58e6e08 Author: Simon McVittie Date: Mon Mar 25 17:28:44 2013 +0000 Remove a remnant of the avatar coming from the environment Bug: https://bugzilla.gnome.org/show_bug.cgi?id=690830 Reviewed-by: Philip Withnall tests/tracker/Makefile.am | 1 - 1 file changed, 1 deletion(-) commit 13113b2fd41d1bdc432142aac600bceee03d61d0 Author: Simon McVittie Date: Tue Mar 26 18:15:00 2013 +0000 Set up tests' backend paths in Vala code One less thing in TESTS_ENVIRONMENT. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=690830 Reviewed-by: Philip Withnall configure.ac | 48 ------------------------------------------ folks/build-conf.vapi | 6 ++++++ tests/eds/Makefile.am | 1 - tests/folks/Makefile.am | 1 - tests/key-file/Makefile.am | 4 ---- tests/lib/Makefile.am | 1 + tests/lib/test-case.vala | 25 ++++++++++++++++++++++ tests/libsocialweb/Makefile.am | 1 - tests/telepathy/Makefile.am | 1 - tests/tracker/Makefile.am | 1 - 10 files changed, 32 insertions(+), 57 deletions(-) commit d232e1084f26c508f241958b6488b016b3c5e125 Author: Patrick Ohly Date: Tue Mar 26 16:53:02 2013 +0100 NEWS: updated to include eds non-blocking change processing NEWS | 2 ++ 1 file changed, 2 insertions(+) commit a480638774368497bce03b1db4297f9436725460 Author: Patrick Ohly Date: Thu Feb 21 19:31:38 2013 +0100 eds: avoid blocking event processing When there are many incoming D-Bus change notifications, processing of other D-Bus messages can be delayed considerably. This commit is a first step towards solving this by caching the change notifications and processing them with lower priority in a glib idle callback. Ordering of the changes relative to each other is preserved, so semantically this is the same as immediate processing. The worst-case scenario is when contacts get added one-by-one to EDS address books while folks is running, because then each change triggers one D-Bus signal. With 2000 contacts and four address books on a fast laptop, the process hosting folks became unresponsive for 137s. The patch reduced that to 0.1s. The downside is an increase of total test runtime of 4%. In the scenario where data is already in EDS when folks starts, the patch reduced response time from 2.3s to 0.2s. See https://bugs.freedesktop.org/show_bug.cgi?id=60851#c6 for details. backends/eds/lib/edsf-persona-store.vala | 127 +++++++++++++++++++++++++++++++ 1 file changed, 127 insertions(+) commit 4a5d0e0694995e9bb7db69d6b70452f883c2ccf5 Author: Patrick Ohly Date: Mon Mar 25 15:39:33 2013 +0100 EDS testing: allow EDS to add additional phone parameters When EDS is compiled with libphonenumber support, it automatically computes a normalized E.164 representation of each phone number and returns it as an additional X-EVOLUTION-E164 parameter. This broke the strict phone_fd.equals check in set-phones, because it compared against a PhoneFieldDetails without that parameter. Now the test only looks for a phone number with "1234" as value and checks for the expected type after returning from the event loop. tests/eds/set-phones.vala | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-) commit f7035a7e21ef37329cf4fea9fb569d94185d5751 Author: Patrick Ohly Date: Mon Mar 25 14:37:26 2013 +0100 testing: avoid false warning When FOLKS_BACKEND_PATH is set to the build dirs during testing, the "content type of '%s' appears to be '%s' which looks suspicious. Have you installed shared-mime-info?" warning gets triggered repeatedly, because these dirs contain all kinds of files (executables, compiler dependency files, etc.) which are not expected in the normal install location. This is annoying when running a test with "make .gdb" because gdb stops on a glib trace point for each warning. Therefore disable the warning when FOLKS_BACKEND_PATH is set. Extending the whitelist has the drawback that it might not catch all files that can appear there in the future. folks/backend-store.vala | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) commit 9064f78a3d57f1141eb67b247aa2627accf79e24 Author: Patrick Ohly Date: Mon Mar 25 14:30:48 2013 +0100 testing: do not require telepathy Previously, all testing was disabled when the Telepathy backend was disabled. That is too strict. For example, the EDS backend tests can work without it. Only the core folks tests and of course the Telepathy tests depend on the Telepathy backend and thus must be disabled when that backend is disabled. Adding the TP backend path to the FOLKS_BACKEND_PATH env variable must be conditional, otherwise there are errors about not finding that .so file when running the other tests. configure.ac | 7 ++++--- tests/Makefile.am | 3 +-- 2 files changed, 5 insertions(+), 5 deletions(-) commit 7f1fd0dd0487020c33c8519f5780a9c4964c2f18 Author: Shankar Prasad Date: Mon Mar 25 23:14:36 2013 +0530 Updated kn translations po/kn.po | 220 ++++++++++++++++++++++++++++++++++----------------------------- 1 file changed, 119 insertions(+), 101 deletions(-) commit 2f0521a5f08651cd64fc051dd75174d6a2a4545f Author: Simon McVittie Date: Wed Mar 20 18:54:51 2013 +0000 Fix comment for get_built_test_data() Bug: https://bugzilla.gnome.org/show_bug.cgi?id=696104 Reviewed-by: Philip Withnall tests/lib/test-utils.vala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 99001d4dbc9cc091e234e603ab9d249f8a29d52c Author: Krishnababu Krothapalli Date: Mon Mar 25 15:13:40 2013 +0530 Updated Telugu Translations po/te.po | 224 ++++++++++++++++++++++++++++++++++----------------------------- 1 file changed, 122 insertions(+), 102 deletions(-) commit 71d25785a954561d64312012b383151822c35618 Author: Ani Peter Date: Mon Mar 25 10:58:42 2013 +0530 Completed for Malayalam po/ml.po | 184 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 95 insertions(+), 89 deletions(-) commit c12f9d80f1dc837bcd9656d33f2eba7a9e352b0d Author: Arash Mousavi Date: Sat Mar 23 19:52:34 2013 +0430 L10N: Updated Persian Translation po/fa.po | 253 +++++++++++++++++++++++++++++++++++++-------------------------- 1 file changed, 148 insertions(+), 105 deletions(-) commit bf8367a5e2fe60a88e0f2ea235af7bd31fb1dd91 Author: Yuri Myasoedov Date: Sat Mar 23 17:22:57 2013 +0400 Updated Russian translation po/ru.po | 224 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 119 insertions(+), 105 deletions(-) commit fadca9937982a4757530766fc3c1a39240abb1a5 Author: ManojKumar Giri Date: Fri Mar 22 19:12:47 2013 +0530 Updated Odia Language along with FUEL implementation po/or.po | 184 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 95 insertions(+), 89 deletions(-) commit c742541d4b0144c9f2760fd5c3203676108c5948 Author: Sandeep Sheshrao Shedmake Date: Fri Mar 22 16:04:09 2013 +0530 Updated Marathi Translations po/mr.po | 206 ++++++++++++++++++++++++++++++++++----------------------------- 1 file changed, 110 insertions(+), 96 deletions(-) commit 3693c8591fdd117c2eabac8026284565685697a0 Author: Shantha kumar Date: Fri Mar 22 14:46:26 2013 +0530 Tamil Translations Updated po/ta.po | 202 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 104 insertions(+), 98 deletions(-) commit fa1474579de9052832ea11cc74fc75a6784d826c Author: Rajesh Ranjan Date: Thu Mar 21 13:22:03 2013 +0530 hindi translation po/hi.po | 186 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 96 insertions(+), 90 deletions(-) commit 29b4a35dc58deeec811e9958c74796c7cc6f6454 Author: Simon McVittie Date: Wed Mar 20 18:37:54 2013 +0000 Add missing setlocale calls to helper binaries tests/eds/helper-create-many-contacts.vala | 2 ++ tests/eds/helper-delete-contacts.vala | 2 ++ tests/eds/helper-prepare-aggregator.vala | 2 ++ 3 files changed, 6 insertions(+) commit c8c1642adb85c7bbe2baf3c0a15f4994bcdb270d Author: Simon McVittie Date: Mon Mar 18 20:28:20 2013 +0000 Add a performance test for contacts in e-d-s tests/eds/Makefile.am | 5 + tests/eds/perf.vala | 406 ++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 411 insertions(+) commit 1f3f85537d501a1ff720b4ef726ac99e7b5d8571 Author: Simon McVittie Date: Wed Mar 20 16:42:35 2013 +0000 eds test: add some helper programs for performance testing tests/eds/Makefile.am | 22 +++- tests/eds/helper-create-many-contacts.vala | 168 ++++++++++++++++++++++++++ tests/eds/helper-delete-contacts.vala | 92 +++++++++++++++ tests/eds/helper-prepare-aggregator.vala | 184 +++++++++++++++++++++++++++++ tests/lib/test-utils.vala | 41 +++++++ 5 files changed, 505 insertions(+), 2 deletions(-) commit 6b42717eb7982478b1f94875ad585305eaa07cc0 Author: Simon McVittie Date: Wed Mar 20 16:03:14 2013 +0000 Simplify tests that can time out There are basically two patterns: * something should stop the main loop within n seconds; if not, that's failure (this is now loop_run_with_timeout) * run the main loop for n seconds, then check whether things we wanted to happen happened (this is now loop_run_with_non_fatal_timeout) The latter is basically a bug in itself; I'm not going to fix that right now, but I did mark it as deprecated. In both cases, we want to adjust the timeout for running under Valgrind or Callgrind, which makes everything slow. tests/eds/add-persona.vala | 8 +- tests/eds/anti-linking.vala | 18 +--- tests/eds/avatar-details.vala | 8 +- tests/eds/create-remove-stores.vala | 11 +-- tests/eds/email-details.vala | 8 +- tests/eds/enable-disable-stores.vala | 11 +-- tests/eds/im-details.vala | 8 +- tests/eds/individual-retrieval.vala | 8 +- tests/eds/link-personas-diff-stores.vala | 9 +- tests/eds/link-personas.vala | 15 +--- tests/eds/linkable-properties.vala | 10 +-- tests/eds/name-details.vala | 8 +- tests/eds/persona-store-tests.vala | 8 +- tests/eds/phone-details.vala | 8 +- tests/eds/postal-address-details.vala | 8 +- tests/eds/remove-persona.vala | 8 +- tests/eds/removing-contacts.vala | 7 +- tests/eds/set-avatar.vala | 17 +--- tests/eds/set-birthday.vala | 7 +- tests/eds/set-emails.vala | 7 +- tests/eds/set-gender.vala | 8 +- tests/eds/set-im-addresses.vala | 7 +- tests/eds/set-is-favourite.vala | 8 +- tests/eds/set-names.vala | 7 +- tests/eds/set-notes.vala | 7 +- tests/eds/set-phones.vala | 7 +- tests/eds/set-postal-addresses.vala | 7 +- tests/eds/set-properties-race.vala | 7 +- tests/eds/set-roles.vala | 7 +- tests/eds/set-structured-name.vala | 7 +- tests/eds/set-urls.vala | 7 +- tests/eds/store-removed.vala | 20 +---- tests/eds/updating-contacts.vala | 7 +- tests/folks/aggregation.vala | 96 +++------------------- tests/folks/init.vala | 11 +-- tests/key-file/individual-retrieval.vala | 21 +---- tests/lib/libsocialweb/test-case.vala | 7 +- tests/lib/test-utils.vala | 77 +++++++++++++++++ tests/libsocialweb/aggregation.vala | 14 +--- tests/libsocialweb/dummy-lsw.vala | 28 +------ tests/telepathy/individual-properties.vala | 36 +------- tests/telepathy/individual-retrieval.vala | 18 +--- tests/telepathy/init.vala | 10 +-- tests/telepathy/persona-store-capabilities.vala | 12 +-- tests/tracker/add-contact.vala | 8 +- tests/tracker/add-persona.vala | 8 +- tests/tracker/additional-names-updates.vala | 8 +- tests/tracker/avatar-details-interface.vala | 8 +- tests/tracker/avatar-updates.vala | 8 +- tests/tracker/birthday-details-interface.vala | 8 +- tests/tracker/birthday-updates.vala | 8 +- tests/tracker/default-contact.vala | 8 +- tests/tracker/duplicated-emails.vala | 8 +- tests/tracker/duplicated-phones.vala | 8 +- tests/tracker/email-details-interface.vala | 8 +- tests/tracker/emails-updates.vala | 8 +- tests/tracker/family-name-updates.vala | 8 +- tests/tracker/favourite-details-interface.vala | 8 +- tests/tracker/favourite-updates.vala | 8 +- tests/tracker/fullname-updates.vala | 8 +- tests/tracker/gender-details-interface.vala | 8 +- tests/tracker/given-name-updates.vala | 8 +- tests/tracker/im-details-interface.vala | 8 +- tests/tracker/imaddresses-updates.vala | 8 +- tests/tracker/individual-retrieval.vala | 8 +- tests/tracker/link-personas-via-local-ids.vala | 8 +- tests/tracker/link-personas.vala | 8 +- tests/tracker/match-all.vala | 8 +- tests/tracker/match-email-addresses.vala | 8 +- tests/tracker/match-im-addresses.vala | 8 +- tests/tracker/match-known-emails.vala | 8 +- tests/tracker/match-name.vala | 8 +- tests/tracker/match-phone-number.vala | 8 +- tests/tracker/name-details-interface.vala | 8 +- tests/tracker/nickname-updates.vala | 8 +- tests/tracker/note-details-interface.vala | 8 +- tests/tracker/phone-details-interface.vala | 8 +- tests/tracker/phones-updates.vala | 8 +- .../tracker/postal-address-details-interface.vala | 8 +- tests/tracker/prefix-name-updates.vala | 8 +- tests/tracker/remove-contact.vala | 8 +- tests/tracker/remove-persona.vala | 8 +- tests/tracker/role-details-interface.vala | 8 +- tests/tracker/set-avatar.vala | 8 +- tests/tracker/set-birthday.vala | 8 +- tests/tracker/set-duplicate-email.vala | 8 +- tests/tracker/set-emails.vala | 8 +- tests/tracker/set-favourite.vala | 8 +- tests/tracker/set-full-name.vala | 8 +- tests/tracker/set-gender.vala | 8 +- tests/tracker/set-im-addresses.vala | 8 +- tests/tracker/set-nickname.vala | 8 +- tests/tracker/set-notes.vala | 8 +- tests/tracker/set-null-avatar.vala | 8 +- tests/tracker/set-phones.vala | 8 +- tests/tracker/set-postal-addresses.vala | 8 +- tests/tracker/set-roles.vala | 8 +- tests/tracker/set-structured-name.vala | 8 +- tests/tracker/set-urls.vala | 8 +- tests/tracker/suffix-name-updates.vala | 8 +- tests/tracker/url-details-interface.vala | 8 +- tests/tracker/website-updates.vala | 8 +- 102 files changed, 205 insertions(+), 887 deletions(-) commit 733d0733579fe9872575e13d1f930c075572ee89 Author: Travis Reitter Date: Wed Mar 20 12:43:23 2013 -0700 build: ensure libtp-test-contactlist is built before its dependents Autotools somehow wasn't picking up the dependencies correctly, so this forces it to build the support library first. As the comment says, there's probably a better fix but time is precious. tests/lib/Makefile.am | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 20066118bb3948a185a369e0b9ff26fd16ee2685 Author: Simon McVittie Date: Wed Mar 20 16:59:03 2013 +0000 NEWS for locale bits NEWS | 1 + 1 file changed, 1 insertion(+) commit 93d0f7d220588afc3b7521d2428426a8863267dd Author: Simon McVittie Date: Wed Mar 20 11:34:37 2013 +0000 TestCase: set locale from the environment This fixes an annoyance I'd had for a while: UTF-8 arrows etc. in debug messages came out as "?", because until we call setlocale() we're in the C locale, whose character set is ASCII (and some layer of library responds by transcoding our strings into ASCII). With this change, running the tests in en_GB.UTF-8 results in Unicode arrows and more comprehensible output. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=696179 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/lib/test-case.vala | 2 ++ 1 file changed, 2 insertions(+) commit 0f8247ac2fe9f87207a0c4de2023b5ca74478de6 Author: Simon McVittie Date: Wed Mar 20 11:27:21 2013 +0000 folks-inspect, folks-import: initialize localization from the environment Otherwise, $LANG etc. are ignored and we stay in the C locale. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=696179 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tools/import.vala | 1 + tools/inspect/inspect.vala | 1 + 2 files changed, 2 insertions(+) commit c6eace13a213f512b7f4a2ff6704fb22cd654ba7 Author: Seong-ho Cho Date: Thu Mar 21 00:02:03 2013 +0900 Updated Korean translation po/ko.po | 209 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 109 insertions(+), 100 deletions(-) commit 3ea5bb8367c9dc138090213ab3edcbedf97b87a8 Author: Simon McVittie Date: Wed Mar 20 13:41:23 2013 +0000 Add support for running tests under callgrind as well as memcheck Bug https://bugzilla.gnome.org/show_bug.cgi?id=696104 Reviewed-by: Philip Withnall [... and document it in HACKING in response to review -smcv] Signed-off-by: Simon McVittie HACKING | 3 +++ tests/eds/Makefile.am | 1 + valgrind.mk | 7 +++++++ 3 files changed, 11 insertions(+) commit c0935ea5bcb4b1b3db15f2f36a24d990a16dc2f4 Author: Simon McVittie Date: Fri Mar 15 18:22:38 2013 +0000 EdsTest.Backend: add contacts as a batch, not one at a time This should make it much quicker to add contacts in bulk. Bug https://bugzilla.gnome.org/show_bug.cgi?id=696104 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/lib/eds/backend.vala | 31 +++++++++++++++++++------------ 1 file changed, 19 insertions(+), 12 deletions(-) commit 30e36ca1d83256d5870a12bf59273f9681f42931 Author: Simon McVittie Date: Fri Mar 15 18:15:59 2013 +0000 EdsTest.Backend: use an array for contacts This means we don't have to worry about whether prepending is faster than appending, or about Vala getting confused about ownership in linked lists. Bug https://bugzilla.gnome.org/show_bug.cgi?id=696104 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/lib/eds/backend.vala | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) commit ae98b4fae6199b19cabc30a068ada9a8920cbdc5 Author: Simon McVittie Date: Tue Mar 19 14:22:04 2013 +0000 EdsTest.Backend: clear up more thoroughly after tests Bug https://bugzilla.gnome.org/show_bug.cgi?id=690830 Reviewed-by: Philip Withnall [redundant line removed in response to review -smcv] Signed-off-by: Simon McVittie tests/lib/eds/backend.vala | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) commit 850aff1ab637b7b9fcf2818e6e822f115ff78c8c Author: Simon McVittie Date: Tue Mar 19 17:06:03 2013 +0000 Add infrastructure for finding test data files, and use it for avatars Again, I've speculatively added support for a FOLKS_TESTS_INSTALLED variable, because one day I'd like "make installcheck" to work. Bug https://bugzilla.gnome.org/show_bug.cgi?id=690830 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/eds/Makefile.am | 2 -- tests/eds/add-persona.vala | 3 ++- tests/eds/avatar-details.vala | 3 ++- tests/eds/set-avatar.vala | 6 +++-- tests/folks/Makefile.am | 2 -- tests/folks/avatar-cache.vala | 2 +- tests/lib/Makefile.am | 1 + tests/lib/eds/test-case.vala | 2 +- tests/lib/test-utils.vala | 38 +++++++++++++++++++++++++++++ tests/lib/tracker/test-case.vala | 2 +- tests/tracker/Makefile.am | 1 - tests/tracker/add-persona.vala | 3 ++- tests/tracker/avatar-details-interface.vala | 3 ++- tests/tracker/set-avatar.vala | 3 ++- 14 files changed, 56 insertions(+), 15 deletions(-) commit 1f74d5db4b62ebf5b9c53d4ba84ab632cde35a39 Author: Simon McVittie Date: Tue Mar 19 16:55:44 2013 +0000 Simplify how we get PACKAGE_DATADIR DATA_DIR and PACKAGE_DATADIR appear to have been intended to both be ${prefix}/share/folks, but due to a typo (sharedir vs. shareddir) DATA_DIR was actually defined to an empty string. Neither is actually used anywhere at the moment. Bug https://bugzilla.gnome.org/show_bug.cgi?id=690830 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall folks/Makefile.am | 3 --- folks/build-conf.vapi | 6 +++--- 2 files changed, 3 insertions(+), 6 deletions(-) commit 08a5276fac3796621831ccc451c3be173073d748 Author: Simon McVittie Date: Wed Mar 20 10:51:08 2013 +0000 NEWS: describe the change to tools' locale search path NEWS | 6 ++++++ 1 file changed, 6 insertions(+) commit cc0f932aa3ee373b604741b7b7fc23db1280f7c6 Author: Simon McVittie Date: Tue Mar 19 16:53:36 2013 +0000 tools: use the right locale directory I happened to notice that they're misusing $(pkgdatadir) - $(pkgdatadir) is $(datadir)/$(PACKAGE), i.e. typically /usr/share/folks, but localization is installed to $(localedir), typically /usr/share/locale. This resulted in the tools looking in /opt/gnome-3.8/share/folks/locale in my installation, instead of the correct /opt/gnome-3.8/share/locale. tools/Makefile.am | 2 +- tools/inspect/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 9bcb7f7852009c2dca2475d7fec10d5be5e40bc3 Author: Simon McVittie Date: Mon Mar 18 19:34:17 2013 +0000 Add infrastructure to run helper test binaries I've included basic infrastructure to run them from an installed path instead of the builddir, because there seems to be considerable interest in that at the moment. Bug https://bugzilla.gnome.org/show_bug.cgi?id=690830 Reviewed-by: Philip Withnall [document capture_stdout in response to review -smcv] Signed-off-by: Simon McVittie folks/build-conf.vapi | 9 +++++++++ tests/lib/Makefile.am | 4 ++++ tests/lib/test-utils.vala | 39 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 52 insertions(+) commit 67c7ae109cad3003a7b87001084fd849b86a68d1 Author: Simon McVittie Date: Tue Mar 19 12:43:21 2013 +0000 In tests that do not rely on with-session-bus*.sh, use a transient $HOME This is one more way in which we can avoid touching the user's real files. Bug https://bugzilla.gnome.org/show_bug.cgi?id=690830 Reviewed-by: Philip Withnall [use "this." in response to review -smcv] Signed-off-by: Simon McVittie tests/lib/Makefile.am | 1 + tests/lib/eds/test-case.vala | 7 +++ tests/lib/haze-remove-directory.c | 56 +++++++++++++++++++++ tests/lib/test-case.vala | 101 ++++++++++++++++++++++++++++++++++++++ tests/lib/test-utils.vala | 5 ++ tests/lib/tracker/test-case.vala | 7 +++ 6 files changed, 177 insertions(+) commit 165e6ff8254476246095c769be59d121d3b6edd1 Author: Simon McVittie Date: Tue Mar 19 12:25:42 2013 +0000 Run Telepathy test cases under GTestDBus instead of with-session-bus.sh Bug https://bugzilla.gnome.org/show_bug.cgi?id=690830 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall configure.ac | 1 - tests/folks/Makefile.am | 8 +--- tests/lib/telepathy/contactlist/Makefile.am | 5 +-- tests/lib/telepathy/contactlist/session.conf.in | 54 ------------------------- tests/lib/telepathy/test-case.vala | 20 ++++----- tests/telepathy/Makefile.am | 9 ++--- 6 files changed, 14 insertions(+), 83 deletions(-) commit 40abe98da11f65f58078a102ba1fa6c250cc253f Author: Simon McVittie Date: Tue Mar 19 12:23:34 2013 +0000 Run libsocialweb tests under GTestDBus instead of with-session-bus.sh Bug https://bugzilla.gnome.org/show_bug.cgi?id=690830 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall configure.ac | 1 - tests/lib/libsocialweb/Makefile.am | 5 ---- tests/lib/libsocialweb/session.conf.in | 54 ---------------------------------- tests/lib/libsocialweb/test-case.vala | 21 +++++-------- tests/libsocialweb/Makefile.am | 9 ++---- 5 files changed, 11 insertions(+), 79 deletions(-) commit cf5db863bd92564d3995d829e23787bf3b1daf98 Author: Simon McVittie Date: Tue Mar 19 12:03:57 2013 +0000 LibsocialwebTest.Backend: clean up object registrations in tear_down() Bug: https://bugzilla.gnome.org/show_bug.cgi?id=690830 Reviewed-by: Philip Withnall [more comments in response to review -smcv] Signed-off-by: Simon McVittie tests/lib/libsocialweb/backend.vala | 94 ++++++++++++++++++++++++++++++------- 1 file changed, 76 insertions(+), 18 deletions(-) commit aa81aee77a19b0decb61df453f322fc78405e7d7 Author: Simon McVittie Date: Fri Mar 15 15:35:51 2013 +0000 LibsocialwebTest: don't try to keep ownership of name through tear_down() This is a step towards replacing with-session-bus*.sh with GTestDBus, which cleans up our D-Bus connection while the test is still running. If we do that without this change, then the NameLost callback is triggered when we get disconnected from D-Bus, causing an assertion failure. This also should reduce circular references, by making sure closures that contain "this" get cleaned up. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=690830 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/lib/libsocialweb/backend.vala | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 49bc02747babed6d94119b2222c5072a9716d4af Author: Simon McVittie Date: Wed Mar 20 10:36:26 2013 +0000 Add infrastructure to run tests under GTestDBus For now, all library TestCase subclasses except the one for key-files override this back to "do nothing" and rely on being run under with-session-bus.sh, because I haven't checked whether they survive having the D-Bus session bus disconnected from under them. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=690830 Reviewed-by: Philip Withnall [added comments about the undesirable dbus-1 dependency -smcv] Signed-off-by: Simon McVittie configure.ac | 3 +- tests/lib/Makefile.am | 3 ++ tests/lib/eds/test-case.vala | 6 ++++ tests/lib/libsocialweb/test-case.vala | 6 ++++ tests/lib/telepathy/test-case.vala | 6 ++++ tests/lib/test-case-helper.c | 13 ++++++++ tests/lib/test-case.vala | 57 +++++++++++++++++++++++++++++++++++ tests/lib/tracker/test-case.vala | 6 ++++ 8 files changed, 99 insertions(+), 1 deletion(-) commit a11ff9059f13ed6a8158a2ffd18fd3bac62d65b3 Author: Gianvito Cavasoli Date: Tue Mar 19 22:58:10 2013 +0100 [l10n] Updated Italian translation. po/it.po | 218 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 114 insertions(+), 104 deletions(-) commit 704e4bb9c6378d61a6faf06699688fdf770193b6 Author: Victor Ibragimov Date: Tue Mar 19 22:33:55 2013 +0100 [l10n] Added Tadjik translation po/LINGUAS | 1 + po/tg.po | 682 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 683 insertions(+) commit bcec3e334f01ea936a3d9c636d9597a96f0c0e01 Author: Simon McVittie Date: Mon Mar 18 19:01:59 2013 +0000 all Makefiles: don't ignore or clean .c files not corresponding to Vala This will become more important if we use C to implement fast-paths and faster data structures. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695381 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall backends/eds/Makefile.am | 2 +- backends/key-file/Makefile.am | 2 +- backends/libsocialweb/Makefile.am | 2 +- backends/ofono/Makefile.am | 2 +- backends/telepathy/Makefile.am | 2 +- backends/tracker/Makefile.am | 2 +- folks/Makefile.am | 4 ++-- tests/lib/Makefile.am | 2 +- tests/lib/eds/Makefile.am | 2 +- tests/lib/key-file/Makefile.am | 2 +- tests/lib/libsocialweb/Makefile.am | 2 +- tests/lib/telepathy/Makefile.am | 2 +- tests/lib/tracker/Makefile.am | 2 +- tools/Makefile.am | 2 +- tools/inspect/Makefile.am | 2 +- 15 files changed, 16 insertions(+), 16 deletions(-) commit 8268c6efbe20a9274dc1b4ad2f61b18406dfb86c Author: Simon McVittie Date: Mon Mar 18 19:00:43 2013 +0000 TestCase: avoid circular refs between GTest and this Instead of running tests via the Adaptor inner class, run them via a C helper that takes a weak ref to the TestCase. This relies on the caller keeping a ref to the TestCase until after Test.run() - but I recently converted the tests to do exactly that, so that's OK. Adding a debug message which prints this.ref_count to final_tear_down() reveals that some of our regression tests still leak the TestCase, but many don't now. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695381 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/lib/Makefile.am | 10 ++++- tests/lib/test-case-helper.c | 91 ++++++++++++++++++++++++++++++++++++++++++++ tests/lib/test-case.vala | 50 ++++++------------------ 3 files changed, 112 insertions(+), 39 deletions(-) commit afb97caf1afd2e78daf43b702da9a64172151216 Author: Simon McVittie Date: Mon Mar 18 12:52:40 2013 +0000 All tests: switch to a calling convention that does not rely on leaking The standard main() used in each test relied on the fact that get_suite() kept a ref to the TestCase subclass instance, which would be stored in the global variables of the GTest infrastructure, resulting in the TestCase never being freed and its final_teardown() never being executed. That's undesirable if final_teardown() is going to do something significant, like terminating a temporary session bus. As a first step towards that, run the tests with the TestCase subclass instance globally referenced (so that the version passed to GTest can eventually be a weak reference), and explicitly run final_tear_down() so that even if there is a ref leak (as there is now), it gets executed. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695381 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/eds/add-contacts-stress-test.vala | 6 +++--- tests/eds/add-persona.vala | 6 +++--- tests/eds/anti-linking.vala | 6 +++--- tests/eds/avatar-details.vala | 6 +++--- tests/eds/create-remove-stores.vala | 6 +++--- tests/eds/email-details.vala | 6 +++--- tests/eds/enable-disable-stores.vala | 6 +++--- tests/eds/im-details.vala | 6 +++--- tests/eds/individual-retrieval.vala | 6 +++--- tests/eds/link-personas-diff-stores.vala | 6 +++--- tests/eds/link-personas.vala | 6 +++--- tests/eds/linkable-properties.vala | 6 +++--- tests/eds/name-details.vala | 6 +++--- tests/eds/persona-store-tests.vala | 6 +++--- tests/eds/phone-details.vala | 6 +++--- tests/eds/postal-address-details.vala | 6 +++--- tests/eds/remove-persona.vala | 6 +++--- tests/eds/removing-contacts.vala | 6 +++--- tests/eds/set-avatar.vala | 6 +++--- tests/eds/set-birthday.vala | 6 +++--- tests/eds/set-emails.vala | 6 +++--- tests/eds/set-gender.vala | 6 +++--- tests/eds/set-im-addresses.vala | 6 +++--- tests/eds/set-is-favourite.vala | 6 +++--- tests/eds/set-names.vala | 6 +++--- tests/eds/set-notes.vala | 6 +++--- tests/eds/set-phones.vala | 6 +++--- tests/eds/set-postal-addresses.vala | 6 +++--- tests/eds/set-properties-race.vala | 6 +++--- tests/eds/set-roles.vala | 6 +++--- tests/eds/set-structured-name.vala | 6 +++--- tests/eds/set-urls.vala | 6 +++--- tests/eds/store-removed.vala | 6 +++--- tests/eds/updating-contacts.vala | 6 +++--- tests/folks/abstract-field-details.vala | 6 +++--- tests/folks/aggregation.vala | 6 +++--- tests/folks/async-locking.vala | 6 +++--- tests/folks/avatar-cache.vala | 6 +++--- tests/folks/backend-loading.vala | 6 +++--- tests/folks/init.vala | 6 +++--- tests/folks/object-cache.vala | 6 +++--- tests/folks/utils.vala | 6 +++--- tests/key-file/individual-retrieval.vala | 6 +++--- tests/lib/test-case.vala | 7 ++++++- tests/libsocialweb/aggregation.vala | 6 +++--- tests/libsocialweb/dummy-lsw.vala | 6 +++--- tests/telepathy/individual-properties.vala | 6 +++--- tests/telepathy/individual-retrieval.vala | 6 +++--- tests/telepathy/init.vala | 6 +++--- tests/telepathy/persona-store-capabilities.vala | 6 +++--- tests/tracker/add-contact.vala | 6 +++--- tests/tracker/add-persona.vala | 6 +++--- tests/tracker/additional-names-updates.vala | 6 +++--- tests/tracker/avatar-details-interface.vala | 6 +++--- tests/tracker/avatar-updates.vala | 6 +++--- tests/tracker/birthday-details-interface.vala | 6 +++--- tests/tracker/birthday-updates.vala | 6 +++--- tests/tracker/default-contact.vala | 6 +++--- tests/tracker/duplicated-emails.vala | 6 +++--- tests/tracker/duplicated-phones.vala | 6 +++--- tests/tracker/email-details-interface.vala | 6 +++--- tests/tracker/emails-updates.vala | 6 +++--- tests/tracker/family-name-updates.vala | 6 +++--- tests/tracker/favourite-details-interface.vala | 6 +++--- tests/tracker/favourite-updates.vala | 6 +++--- tests/tracker/fullname-updates.vala | 6 +++--- tests/tracker/gender-details-interface.vala | 6 +++--- tests/tracker/given-name-updates.vala | 6 +++--- tests/tracker/im-details-interface.vala | 6 +++--- tests/tracker/imaddresses-updates.vala | 6 +++--- tests/tracker/individual-retrieval.vala | 6 +++--- tests/tracker/link-personas-via-local-ids.vala | 6 +++--- tests/tracker/link-personas.vala | 6 +++--- tests/tracker/match-all.vala | 6 +++--- tests/tracker/match-email-addresses.vala | 6 +++--- tests/tracker/match-im-addresses.vala | 6 +++--- tests/tracker/match-known-emails.vala | 6 +++--- tests/tracker/match-name.vala | 6 +++--- tests/tracker/match-phone-number.vala | 6 +++--- tests/tracker/name-details-interface.vala | 6 +++--- tests/tracker/nickname-updates.vala | 6 +++--- tests/tracker/note-details-interface.vala | 6 +++--- tests/tracker/phone-details-interface.vala | 6 +++--- tests/tracker/phones-updates.vala | 6 +++--- tests/tracker/postal-address-details-interface.vala | 6 +++--- tests/tracker/prefix-name-updates.vala | 6 +++--- tests/tracker/remove-contact.vala | 6 +++--- tests/tracker/remove-persona.vala | 6 +++--- tests/tracker/role-details-interface.vala | 6 +++--- tests/tracker/set-avatar.vala | 6 +++--- tests/tracker/set-birthday.vala | 6 +++--- tests/tracker/set-duplicate-email.vala | 6 +++--- tests/tracker/set-emails.vala | 6 +++--- tests/tracker/set-favourite.vala | 6 +++--- tests/tracker/set-full-name.vala | 6 +++--- tests/tracker/set-gender.vala | 6 +++--- tests/tracker/set-im-addresses.vala | 6 +++--- tests/tracker/set-nickname.vala | 6 +++--- tests/tracker/set-notes.vala | 6 +++--- tests/tracker/set-null-avatar.vala | 6 +++--- tests/tracker/set-phones.vala | 6 +++--- tests/tracker/set-postal-addresses.vala | 6 +++--- tests/tracker/set-roles.vala | 6 +++--- tests/tracker/set-structured-name.vala | 6 +++--- tests/tracker/set-urls.vala | 6 +++--- tests/tracker/suffix-name-updates.vala | 6 +++--- tests/tracker/url-details-interface.vala | 6 +++--- tests/tracker/website-updates.vala | 6 +++--- 108 files changed, 327 insertions(+), 322 deletions(-) commit 452035512b3b7a78779a9e85ea9b215e7557930b Author: Simon McVittie Date: Mon Mar 18 12:36:18 2013 +0000 For symmetry, nullify sets in tear_down() if created in set_up() Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695381 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/eds/persona-store-tests.vala | 8 +++++++- tests/telepathy/individual-properties.vala | 9 ++++++++- tests/telepathy/persona-store-capabilities.vala | 9 ++++++++- 3 files changed, 23 insertions(+), 3 deletions(-) commit 19a44b01b5dea3df8a6f6fc1b4dcab21054ae097 Author: Simon McVittie Date: Mon Mar 18 19:10:57 2013 +0000 Assert that each D-Bus test case is run in its intended environment This is a safety check so we don't trash the user's real home directory. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695381 Reviewed-by: Philip Withnall [added a comment as per pwithnall's review -smcv] Signed-off-by: Simon McVittie tests/lib/eds/test-case.vala | 8 ++++++++ tests/lib/libsocialweb/test-case.vala | 7 +++++++ tests/lib/telepathy/test-case.vala | 7 +++++++ tests/lib/tracker/test-case.vala | 8 ++++++++ tests/tools/with-session-bus-eds.sh | 3 +++ tests/tools/with-session-bus-tracker.sh | 3 +++ tests/tools/with-session-bus.sh | 3 +++ 7 files changed, 39 insertions(+) commit ed877652b0f51fa1c28e95fab5f5974b1e880c9b Author: Simon McVittie Date: Mon Mar 18 12:06:00 2013 +0000 Document recently-added TestCase subclasses They currently assume that they will be wrapped in with-session-bus*.sh. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695381 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/lib/eds/test-case.vala | 27 ++++++++++ tests/lib/key-file/test-case.vala | 14 +++++ tests/lib/libsocialweb/test-case.vala | 17 ++++++ tests/lib/telepathy/test-case.vala | 99 +++++++++++++++++++++++++++++++++++ tests/lib/test-case.vala | 40 +++++++++++--- tests/lib/tracker/test-case.vala | 21 ++++++++ 6 files changed, 211 insertions(+), 7 deletions(-) commit fb2abc0ab8a72b346d30679df39dd217d092b676 Author: Simon McVittie Date: Thu Mar 14 15:50:06 2013 +0000 LibsocialwebTest.TestCase: defer creation of lsw_backend until set_up() Also destroy it in tear_down(), for symmetry. Since there are only two LSW test cases and neither of them has more than one test, we don't need to worry much about compatibility - it's easy to check. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695381 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/lib/libsocialweb/test-case.vala | 34 ++++++++++++++++------------------ 1 file changed, 16 insertions(+), 18 deletions(-) commit e4de6c5f6dd4eb66a7519afe2d60166c0cb7f0a7 Author: Simon McVittie Date: Thu Mar 14 15:48:26 2013 +0000 tests: limit backends via the environment a bit more directly This makes it more obvious what's enabled and what isn't. We want to make sure that only the intended backends are enabled, because those are the ones for which we've done enough environmental setup (D-Bus, etc.) to make sure they don't "leak out" into the user's real data. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695381 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/data/Makefile.am | 1 - tests/data/backend-store-all.ini | 9 --------- tests/eds/Makefile.am | 4 ---- tests/eds/data/backend-eds-only.ini | 5 ----- tests/folks/Makefile.am | 3 --- tests/key-file/Makefile.am | 4 ---- tests/key-file/data/backend-store-key-file-only.ini | 5 ----- tests/lib/eds/test-case.vala | 4 ++++ tests/lib/key-file/test-case.vala | 3 +++ tests/lib/libsocialweb/test-case.vala | 3 +++ tests/lib/telepathy/test-case.vala | 13 +++++++++++++ tests/lib/test-case.vala | 3 +++ tests/lib/tracker/test-case.vala | 3 +++ tests/libsocialweb/Makefile.am | 4 ---- tests/libsocialweb/aggregation.vala | 2 ++ tests/libsocialweb/data/backend-lsw-only.ini | 5 ----- tests/telepathy/Makefile.am | 4 ---- tests/telepathy/data/backend-store-telepathy-only.ini | 5 ----- tests/tracker/Makefile.am | 4 ---- tests/tracker/data/backend-tracker-only.ini | 6 ------ 20 files changed, 31 insertions(+), 59 deletions(-) commit 039a7ccaae6a5824edab276535f46bc1ed0f4bd1 Author: Simon McVittie Date: Thu Mar 14 14:53:13 2013 +0000 Make EdsTest.TestCase.eds_backend nullable It's null outside the period from set_up() to tear_down(). Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695381 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/lib/eds/test-case.vala | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) commit 6bed8888020653815735c10f8e0a5bc6b7c7467c Author: Simon McVittie Date: Thu Mar 14 14:40:14 2013 +0000 Reduce hard-coding of e-d-s address book names Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695381 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/eds/create-remove-stores.vala | 4 +++- tests/eds/enable-disable-stores.vala | 4 +++- tests/eds/link-personas-diff-stores.vala | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) commit 63cc94f013e4e4e6326d312465c11cf2a9bb456f Author: Simon McVittie Date: Mon Mar 18 11:53:21 2013 +0000 Add subclasses for each category of TestCase Move small amounts of initialization (just the low-hanging fruit) into each subclass. Folks.TestCase is now reserved for tests that don't need any backends or additional services at all. In the process, make TpTestsBackend.tear_down() idempotent, so it's OK if we call it repeatedly. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695381 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/eds/add-contacts-stress-test.vala | 20 +--- tests/eds/add-persona.vala | 20 +--- tests/eds/anti-linking.vala | 35 +++--- tests/eds/avatar-details.vala | 24 +--- tests/eds/create-remove-stores.vala | 16 +-- tests/eds/email-details.vala | 28 +---- tests/eds/enable-disable-stores.vala | 20 ++-- tests/eds/im-details.vala | 24 +--- tests/eds/individual-retrieval.vala | 26 +---- tests/eds/link-personas-diff-stores.vala | 18 +-- tests/eds/link-personas.vala | 25 +---- tests/eds/linkable-properties.vala | 24 ++-- tests/eds/name-details.vala | 26 +---- tests/eds/persona-store-tests.vala | 19 +--- tests/eds/phone-details.vala | 26 +---- tests/eds/postal-address-details.vala | 22 +--- tests/eds/remove-persona.vala | 20 +--- tests/eds/removing-contacts.vala | 26 +---- tests/eds/set-avatar.vala | 30 ++--- tests/eds/set-birthday.vala | 24 +--- tests/eds/set-emails.vala | 24 +--- tests/eds/set-gender.vala | 24 +--- tests/eds/set-im-addresses.vala | 24 +--- tests/eds/set-is-favourite.vala | 24 +--- tests/eds/set-names.vala | 24 +--- tests/eds/set-notes.vala | 24 +--- tests/eds/set-phones.vala | 24 +--- tests/eds/set-postal-addresses.vala | 24 +--- tests/eds/set-properties-race.vala | 24 +--- tests/eds/set-roles.vala | 24 +--- tests/eds/set-structured-name.vala | 24 +--- tests/eds/set-urls.vala | 24 +--- tests/eds/store-removed.vala | 27 +---- tests/eds/updating-contacts.vala | 26 +---- tests/folks/Makefile.am | 5 + tests/folks/abstract-field-details.vala | 8 -- tests/folks/aggregation.vala | 91 +++++++--------- tests/folks/async-locking.vala | 5 +- tests/folks/avatar-cache.vala | 2 + tests/folks/backend-loading.vala | 13 +-- tests/folks/init.vala | 41 +++---- tests/folks/object-cache.vala | 2 + tests/folks/utils.vala | 8 -- tests/key-file/individual-retrieval.vala | 13 +-- tests/lib/Makefile.am | 6 +- tests/lib/eds/Makefile.am | 6 + tests/lib/eds/test-case.vala | 66 +++++++++++ tests/lib/folks-test.deps | 5 + tests/lib/key-file/Makefile.am | 15 ++- tests/lib/key-file/kf-test.deps | 5 + tests/lib/key-file/test-case.vala | 33 ++++++ tests/lib/libsocialweb/Makefile.am | 7 ++ tests/lib/libsocialweb/test-case.vala | 70 ++++++++++++ tests/lib/telepathy/Makefile.am | 65 +++++++++++ tests/lib/telepathy/contactlist/backend.c | 6 + tests/lib/telepathy/test-case.vala | 121 +++++++++++++++++++++ tests/lib/telepathy/tpf-test.deps | 7 ++ tests/lib/test-case.vala | 18 +++ tests/lib/tracker/Makefile.am | 6 + tests/lib/tracker/test-case.vala | 43 ++++++++ tests/libsocialweb/aggregation.vala | 32 ++---- tests/libsocialweb/dummy-lsw.vala | 34 +----- tests/telepathy/Makefile.am | 10 ++ tests/telepathy/individual-properties.vala | 19 +--- tests/telepathy/individual-retrieval.vala | 19 +--- tests/telepathy/init.vala | 21 +--- tests/telepathy/persona-store-capabilities.vala | 18 +-- tests/tracker/add-contact.vala | 19 +--- tests/tracker/add-persona.vala | 15 +-- tests/tracker/additional-names-updates.vala | 22 +--- tests/tracker/avatar-details-interface.vala | 18 +-- tests/tracker/avatar-updates.vala | 26 ++--- tests/tracker/birthday-details-interface.vala | 20 +--- tests/tracker/birthday-updates.vala | 24 +--- tests/tracker/default-contact.vala | 19 +--- tests/tracker/duplicated-emails.vala | 14 +-- tests/tracker/duplicated-phones.vala | 14 +-- tests/tracker/email-details-interface.vala | 19 +--- tests/tracker/emails-updates.vala | 31 ++---- tests/tracker/family-name-updates.vala | 22 +--- tests/tracker/favourite-details-interface.vala | 23 +--- tests/tracker/favourite-updates.vala | 26 ++--- tests/tracker/fullname-updates.vala | 22 +--- tests/tracker/gender-details-interface.vala | 20 +--- tests/tracker/given-name-updates.vala | 22 +--- tests/tracker/im-details-interface.vala | 19 +--- tests/tracker/imaddresses-updates.vala | 30 ++--- tests/tracker/individual-retrieval.vala | 21 +--- tests/tracker/link-personas-via-local-ids.vala | 12 +- tests/tracker/link-personas.vala | 11 +- tests/tracker/match-all.vala | 14 +-- tests/tracker/match-email-addresses.vala | 14 +-- tests/tracker/match-im-addresses.vala | 14 +-- tests/tracker/match-known-emails.vala | 14 +-- tests/tracker/match-name.vala | 14 +-- tests/tracker/match-phone-number.vala | 14 +-- tests/tracker/name-details-interface.vala | 21 +--- tests/tracker/nickname-updates.vala | 28 ++--- tests/tracker/note-details-interface.vala | 20 +--- tests/tracker/phone-details-interface.vala | 19 +--- tests/tracker/phones-updates.vala | 30 ++--- .../tracker/postal-address-details-interface.vala | 19 +--- tests/tracker/prefix-name-updates.vala | 22 +--- tests/tracker/remove-contact.vala | 21 +--- tests/tracker/remove-persona.vala | 15 +-- tests/tracker/role-details-interface.vala | 20 +--- tests/tracker/set-avatar.vala | 19 +--- tests/tracker/set-birthday.vala | 19 +--- tests/tracker/set-duplicate-email.vala | 14 +-- tests/tracker/set-emails.vala | 19 +--- tests/tracker/set-favourite.vala | 21 +--- tests/tracker/set-full-name.vala | 19 +--- tests/tracker/set-gender.vala | 19 +--- tests/tracker/set-im-addresses.vala | 19 +--- tests/tracker/set-nickname.vala | 19 +--- tests/tracker/set-notes.vala | 19 +--- tests/tracker/set-null-avatar.vala | 19 +--- tests/tracker/set-phones.vala | 19 +--- tests/tracker/set-postal-addresses.vala | 19 +--- tests/tracker/set-roles.vala | 19 +--- tests/tracker/set-structured-name.vala | 19 +--- tests/tracker/set-urls.vala | 19 +--- tests/tracker/suffix-name-updates.vala | 22 +--- tests/tracker/url-details-interface.vala | 20 +--- tests/tracker/website-updates.vala | 25 ++--- 125 files changed, 961 insertions(+), 1809 deletions(-) commit 3c7319ae32de2b5be24071d10c795e2b7e8c2a39 Author: Rūdolfs Mazurs Date: Sun Mar 17 20:26:33 2013 +0200 Updated Latvian translation po/lv.po | 213 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 111 insertions(+), 102 deletions(-) commit e0500604a63d6a56c99e9cf40da0778160fb5e71 Author: Ask H. Larsen Date: Sun Mar 17 08:26:21 2013 +0100 Updated Danish translation po/da.po | 201 ++++++++++++++++++++++++++++++++++----------------------------- 1 file changed, 107 insertions(+), 94 deletions(-) commit 9801e450628f3655efbb2c55783b0e1d550f9050 Author: Balázs Úr Date: Fri Mar 15 11:51:40 2013 +0100 Updated Hungarian translation po/hu.po | 184 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 95 insertions(+), 89 deletions(-) commit 4be6b0853274f1e939be5fa65a39b25236172818 Author: Duarte Loreto Date: Fri Mar 15 01:27:32 2013 +0000 Updated Portuguese translation and converted to New Spelling (Novo AO) po/pt.po | 231 ++++++++++++++++++++++++++++++++++----------------------------- 1 file changed, 123 insertions(+), 108 deletions(-) commit 22a4f58e77ea3fd0c4ce9aee68c1ab4778b22ce4 Author: Carles Ferrando Date: Fri Mar 15 00:24:19 2013 +0100 [l10n] Updated Catalan (Valencian) translation po/ca@valencia.po | 199 ++++++++++++++++++++++++++++-------------------------- 1 file changed, 104 insertions(+), 95 deletions(-) commit b1b14241fd32d5006c74b06af5a7d122eb7f4386 Author: Gil Forcada Date: Fri Mar 15 00:24:17 2013 +0100 [l10n] Updated Catalan translation po/ca.po | 197 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 103 insertions(+), 94 deletions(-) commit e49bdbd53e422a8cf2cff2e31669522433fb5ef4 Author: Sweta Kothari Date: Thu Mar 14 11:39:57 2013 +0530 Updated gujarati file po/gu.po | 206 ++++++++++++++++++++++++++++++++++----------------------------- 1 file changed, 110 insertions(+), 96 deletions(-) commit f5ab4a1d7a5856c7d13029bdceb83bfa3b5b6af7 Author: Simon McVittie Date: Wed Mar 13 12:30:35 2013 +0000 update NEWS NEWS | 4 ++++ 1 file changed, 4 insertions(+) commit 1fd8b55222f820b65338f9587a328316a35bd22a Author: Simon McVittie Date: Fri Mar 8 15:02:25 2013 +0000 BackendStore: provide an easier way to limit backends via environment If FOLKS_BACKENDS_ALLOWED is set, it's a space-, comma- or colon-separated list of backends to allow, or "all". If unset, the default is "all". Backends not in the list are disabled, even if the keyfile says they ought to be enabled. If FOLKS_BACKENDS_DISABLED is set, it's a space-, comma- or colon-separated list of additional backends to disable. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695381 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall HACKING | 17 +++++++++++ folks/backend-store.vala | 78 ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 95 insertions(+) commit 431930d15817cf1675dc9d1f11755661baab1bcb Author: Simon McVittie Date: Tue Mar 12 14:33:06 2013 +0000 TestCase: fix indentation Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/lib/test-case.vala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f2a0df2d2262c69d23bccf212f3564ac5aa1f81c Author: Simon McVittie Date: Tue Mar 12 15:27:32 2013 +0000 collection comparators: optimize the case of empty collections Comparing integers is a lot faster than constructing one or more GObjects to iterate over the hash table. This saves about 3% of the user CPU time needed to deal with 2049 simple e-d-s Google contacts, each with one email address and no phone numbers etc. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695648 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall folks/utils.vala | 30 +++++++++++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-) commit 89481c9dac3d4a528781c090463045bba691ab31 Author: Simon McVittie Date: Tue Mar 12 17:06:31 2013 +0000 Don't do manual memory management for libsocialweb Contact structs GObject (and hence Vala) already knows how to memory-manage a Contact, because it's a boxed type. Trying to do our own memory-management anyway results in an occasional (50%?) double-free and crash. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695719 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall backends/libsocialweb/lib/swf-persona.vala | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) commit d9d468e84343299e97602ca6685911ae6bc018bf Author: Simon McVittie Date: Tue Mar 12 17:16:18 2013 +0000 update NEWS NEWS | 1 + 1 file changed, 1 insertion(+) commit f574cc5631526dc2d026fb109b6188e539123694 Author: Simon McVittie Date: Tue Mar 12 13:50:56 2013 +0000 Always append to AM_VALAFLAGS, don't replace This avoids losing --target-glib=2.24 (from configure.ac) in certain test modules. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695628 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall tests/eds/Makefile.am | 2 +- tests/folks/Makefile.am | 2 +- tests/key-file/Makefile.am | 2 +- tests/libsocialweb/Makefile.am | 2 +- tests/telepathy/Makefile.am | 2 +- tests/tracker/Makefile.am | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) commit 225f7042476504cedc1b35a7d2c91d7876841ec3 Author: Simon McVittie Date: Mon Mar 11 13:12:02 2013 +0000 Do not assign to VALAFLAGS Users should be able to do "make VALAFLAGS=--enable-experimental-non-null" without overriding necessary flags like --target-glib=2.24. The variable for use by package maintainers is AM_VALAFLAGS. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695628 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall backends/eds/Makefile.am | 3 +-- backends/libsocialweb/Makefile.am | 3 +-- backends/telepathy/Makefile.am | 3 +-- backends/tracker/Makefile.am | 3 +-- configure.ac | 4 ++-- tests/lib/Makefile.am | 2 +- tests/lib/eds/Makefile.am | 2 +- tests/lib/key-file/Makefile.am | 2 +- tests/lib/libsocialweb/Makefile.am | 2 +- tests/lib/tracker/Makefile.am | 2 +- tools/Makefile.am | 3 +-- tools/inspect/Makefile.am | 3 +-- 12 files changed, 13 insertions(+), 19 deletions(-) commit c8155b0232b9e084bc8f5c76239a3192eabb6ae6 Author: Nilamdyuti Goswami Date: Tue Mar 12 18:46:16 2013 +0530 Assamese translation updated for gnome 3.8 po/as.po | 186 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 96 insertions(+), 90 deletions(-) commit 1beab23520bbca100bcf54006ef4958783002413 Author: Philip Withnall Date: Mon Mar 11 20:16:02 2013 +0000 HACKING: Update documentation for strict-non-null mode Mention how to compile with --enable-experimental-non-null. See: https://bugzilla.gnome.org/show_bug.cgi?id=695628 HACKING | 2 ++ 1 file changed, 2 insertions(+) commit 90b8fbdbf27981fc21fd0282b344b07c66e196f5 Author: Andika Triwidada Date: Mon Mar 11 12:49:22 2013 +0700 Updated Indonesian translation po/id.po | 206 ++++++++++++++++++++++++++++++++++----------------------------- 1 file changed, 110 insertions(+), 96 deletions(-) commit 5418e9b333a6ba36cfefe20f0728b972bdefeb45 Author: Dimitris Spingos Date: Sat Mar 9 15:28:42 2013 +0200 Updated Greek translation po/el.po | 213 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 111 insertions(+), 102 deletions(-) commit 5a1d4aca737192ddc2f3183c713f1973b4394d58 Author: Simon McVittie Date: Fri Mar 8 14:02:39 2013 +0000 Update NEWS with recent changes NEWS | 2 ++ 1 file changed, 2 insertions(+) commit 3ead592946f3b9e9b41196c193228047af9b0834 Author: Simon McVittie Date: Fri Mar 8 13:55:29 2013 +0000 Mostly avoid an expensive multi-map iteration pattern If you have a MultiMap with, say, 100 keys each with 1 value, and you iterate over it like this (pseudocode): for key in keys(): values = get(key) for value in values: do something(key, value) then you have constructed one GObject for the result of keys(), and 100 GObjects for the results of get() (because it returns a read-only view). If you iterate it like this: iter = map_iterator() while iter.next(): do something(iter.key(), iter.value()) there's only one extraneous GObject, the iterator itself. When there are thousands of contacts, as in add-contacts-stress-test, this really starts to matter. This patch doesn't fix every use of get_keys() - some of them do non-trivial work per key as well as per value, making it awkward to convert to map_iterator() - but it's a start. It cuts 'user' CPU time for IndividualAggregator quiescence for an e-d-s Google account with 2049 contacts (reading from cache) by around 3%. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=682903 Reviewed-by: Philip Withnall [note added to HACKING as per Philip's review] Signed-off-by: Simon McVittie HACKING | 4 + backends/eds/lib/edsf-persona.vala | 19 +-- backends/key-file/kf-persona.vala | 19 +-- .../telepathy/lib/tpf-persona-store-cache.vala | 27 ++-- backends/telepathy/lib/tpf-persona-store.vala | 13 +- folks/abstract-field-details.vala | 12 +- folks/individual-aggregator.vala | 169 +++++++++++---------- folks/individual.vala | 30 +--- 8 files changed, 139 insertions(+), 154 deletions(-) commit 1e758bd6f27e260aa43cf7001d595f5f36e5bb93 Author: Matej Urbančič Date: Thu Mar 7 16:59:54 2013 +0100 Updated Slovenian translation po/sl.po | 288 ++++++++++++++++++++++++++++++++++++--------------------------- 1 file changed, 166 insertions(+), 122 deletions(-) commit 04cdac60f1299d772d2aacd1418e97163cd36c83 Author: Ihar Hrachyshka Date: Thu Mar 7 17:15:19 2013 +0300 Updated Belarusian translation. po/be.po | 199 ++++++++++++++++++++++++++++++++++----------------------------- 1 file changed, 106 insertions(+), 93 deletions(-) commit 5f7e4581340da9388472b4018c93c9c39f4167d0 Author: Enrico Nicoletto Date: Thu Mar 7 00:14:36 2013 -0300 Updated Brazilian Portuguese translation po/pt_BR.po | 212 ++++++++++++++++++++++++++++++++---------------------------- 1 file changed, 113 insertions(+), 99 deletions(-) commit a08b1b2f41f34a94c98c35552753d47eee98fcf3 Author: Simon McVittie Date: Thu Feb 28 16:50:08 2013 +0000 Use absolute paths for --vapidir In the rules currently generated by Automake, valac currently runs cd'd into the ${srcdir}. It seems unwise to rely on that, and the only thing that will work regardless of whether ${srcdir} is ".", relative or absolute is its "absolutized" version. Similarly, look in both the ${srcdir} and the ${builddir} for Vala bindings we generate: the ${srcdir} because that's where valac currently puts them, and the ${builddir} because that's where they ought to go in principle. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=694883 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall backends/telepathy/Makefile.am | 9 ++++++--- backends/telepathy/lib/Makefile.am | 13 +++++++++---- folks/Makefile.am | 6 ++++-- tests/folks/Makefile.am | 15 ++++++++++----- tests/telepathy/Makefile.am | 15 ++++++++++----- 5 files changed, 39 insertions(+), 19 deletions(-) commit 36ed61b85c2848fbd0e056579d8164c59aa0d2d7 Author: Simon McVittie Date: Thu Feb 28 16:33:08 2013 +0000 Add -I$(top_srcdir) throughout Automake adds (the equivalent of) -I$(top_builddir) to our CPPFLAGS automatically, so we can #include "config.h". It does not add -I$(top_srcdir). Many things in folks want to #include , so we should always have -I$(top_srcdir) so we can pick that up. Out-of-tree builds previously either didn't work, or relied on having installed folks headers (I'm not sure which). Bug: https://bugzilla.gnome.org/show_bug.cgi?id=694883 Reviewed-by: Philip Withnall [amended to do the same for tracker- and libsocialweb-specifics too -smcv] Signed-off-by: Simon McVittie backends/eds/Makefile.am | 1 + backends/eds/lib/Makefile.am | 1 + backends/key-file/Makefile.am | 1 + backends/libsocialweb/Makefile.am | 1 + backends/libsocialweb/lib/Makefile.am | 1 + backends/ofono/Makefile.am | 1 + backends/telepathy/Makefile.am | 1 + backends/telepathy/lib/Makefile.am | 1 + backends/tracker/Makefile.am | 1 + backends/tracker/lib/Makefile.am | 1 + tests/eds/Makefile.am | 1 + tests/folks/Makefile.am | 1 + tests/key-file/Makefile.am | 1 + tests/lib/Makefile.am | 1 + tests/lib/eds/Makefile.am | 1 + tests/lib/tracker/Makefile.am | 1 + tests/libsocialweb/Makefile.am | 1 + tests/telepathy/Makefile.am | 1 + tests/tracker/Makefile.am | 1 + tools/Makefile.am | 1 + tools/inspect/Makefile.am | 1 + 21 files changed, 21 insertions(+) commit 3bb3e44c673cee5b15896484e626b39c187d6750 Author: Kjartan Maraas Date: Mon Mar 4 15:00:39 2013 +0100 Updated Norwegian bokmål translation po/nb.po | 253 +++++++++++++++++++++++++++++++++++---------------------------- 1 file changed, 141 insertions(+), 112 deletions(-) commit 9a61ac79de3e75b94f917f849d51089272848b80 Author: Mario Blättermann Date: Sun Mar 3 22:00:57 2013 +0100 [l10n] Updated German translation po/de.po | 204 ++++++++++++++++++++++++++++++++++----------------------------- 1 file changed, 109 insertions(+), 95 deletions(-) commit 171a5299d6557263c48c4f1dd22b21d4ae2bff4d Author: Aurimas Černius Date: Sat Mar 2 23:28:03 2013 +0200 Updated Lithuanian translation po/lt.po | 182 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 94 insertions(+), 88 deletions(-) commit f86a70dbef86f4681637135f0b7f555154c42ccc Author: Chao-Hsiung Liao Date: Fri Mar 1 22:14:46 2013 +0800 Updated Traditional Chinese translation(Hong Kong and Taiwan) po/zh_HK.po | 206 ++++++++++++++++++++++++++++++++---------------------------- po/zh_TW.po | 206 ++++++++++++++++++++++++++++++++---------------------------- 2 files changed, 222 insertions(+), 190 deletions(-) commit 485d7e54d5e9d3f69fd793bf8534abcae02f29f8 Author: Мирослав Николић Date: Fri Mar 1 11:17:19 2013 +0100 Updated Serbian translation po/sr.po | 182 +++++++++++++++++++++++++++++---------------------------- po/sr@latin.po | 182 +++++++++++++++++++++++++++++---------------------------- 2 files changed, 188 insertions(+), 176 deletions(-) commit cf22c48be5bc61c99f34f3f1e14ef251374c17f8 Author: Fran Diéguez Date: Tue Feb 26 00:25:30 2013 +0100 Updated Galician translations po/gl.po | 183 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 94 insertions(+), 89 deletions(-) commit a98eca537bfc9ecfdada790d5043ecf57f1d994f Author: Piotr Drąg Date: Sun Feb 24 02:39:27 2013 +0100 Updated Polish translation po/pl.po | 105 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 55 insertions(+), 50 deletions(-) commit f700c884c13952d5a5b23ad252940313b7d05411 Author: Travis Reitter Date: Fri Feb 22 09:10:35 2013 -0800 build: Include location-details.c in POTFILES.skip This fixes a break in distcheck po/POTFILES.skip | 1 + 1 file changed, 1 insertion(+) commit 202855cb6c4ebf05b80531525a4fc3f194c91282 Author: Travis Reitter Date: Fri Feb 22 08:59:26 2013 -0800 build: Use @return instead of unsupported @returns valadoc This was breaking the build when making docs folks/location-details.vala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 733bd27352b6aefc24ff5a51caf25fa9edef3b03 Author: Gheyret Kenji Date: Fri Feb 22 22:22:06 2013 +0900 Updated Uyghur translation Signed-off-by: Gheyret Kenji po/ug.po | 714 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 647 insertions(+), 67 deletions(-) commit 0cffbabde39d93d8107bf8453f3ec8f79da9a26e Author: Gheyret Kenji Date: Fri Feb 22 22:19:56 2013 +0900 Updated Uyghur translation Signed-off-by: Gheyret Kenji po/ug.po | 714 ++++++--------------------------------------------------------- 1 file changed, 67 insertions(+), 647 deletions(-) commit 850aab9a6b2b7ccb03c5ad21e9613e4fe72ec9cf Author: Gheyret Kenji Date: Fri Feb 22 22:09:51 2013 +0900 Updated Uyghur translation Signed-off-by: Gheyret Kenji po/ug.po | 142 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 74 insertions(+), 68 deletions(-) commit ba7cdd3c81d8a2374435d25f3bcf418e41482615 Author: Marek Černocký Date: Fri Feb 22 10:43:48 2013 +0100 Updated Czech translation po/cs.po | 179 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 92 insertions(+), 87 deletions(-) commit c8017c56e08bffed2dfa61095d31e6d32b9ccd57 Author: A S Alam Date: Fri Feb 22 01:38:16 2013 +0000 Punjabi: Translation updated (aalam) po/pa.po | 206 ++++++++++++++++++++++++++++++++++----------------------------- 1 file changed, 110 insertions(+), 96 deletions(-) commit 5f58a0721f0aa929be07bdb7739d0efb3ef2a8ee Author: Daniel Mustieles Date: Thu Feb 21 16:54:25 2013 +0100 Updated Spanish translation po/es.po | 205 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 104 insertions(+), 101 deletions(-) commit 40cd2798a75558015634fc260a46e77c3c4ff3a5 Author: Alexandre Franke Date: Wed Feb 20 20:19:11 2013 +0100 Update French translation po/fr.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 11edfc4b42e30e5d42e1df69ab95e2244aadcf2a Author: Alexandre Franke Date: Wed Feb 20 20:18:37 2013 +0100 Update French translation po/fr.po | 181 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 93 insertions(+), 88 deletions(-) commit 75ff3f87dc89ed760382267d76823aaaebf7a718 Author: Patrick Ohly Date: Fri Feb 8 15:23:13 2013 +0100 support geo location information This adds "Location" class with latitude and longitude and single-valued "LocationDetails" which exposes that information for a contact. The logic for choosing "the best" among many locations from different personas is left out for now. Instead folks picks according to the default ordering of single values, which prefers values from the primary store. The EDS backend provides, creates and writes the GEO property as location. backends/eds/lib/edsf-persona-store.vala | 37 ++++++++- backends/eds/lib/edsf-persona.vala | 61 ++++++++++++++ folks/Makefile.am | 1 + folks/individual.vala | 49 +++++++++++- folks/location-details.vala | 131 +++++++++++++++++++++++++++++++ folks/persona-store.vala | 8 ++ po/POTFILES.in | 1 + 7 files changed, 285 insertions(+), 3 deletions(-) commit d7846d8d220942d89212b5af045787ae2d47c1f1 Author: Marek Černocký Date: Tue Feb 19 11:13:28 2013 +0100 Updated Czech translation po/cs.po | 157 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 83 insertions(+), 74 deletions(-) commit 26310e79259dda6ee795361fb3d7164ea2d10eb3 Author: Philip Withnall Date: Mon Feb 18 18:28:04 2013 +0000 eds: Fix the type of a parameter in add_persona_from_details() This build breaker was introduced in commit dcc558d87d113dae0aa8721db3d80261c08dee57. backends/eds/lib/edsf-persona-store.vala | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) commit dcc558d87d113dae0aa8721db3d80261c08dee57 Author: Patrick Ohly Date: Mon Feb 18 12:19:08 2013 +0100 eds: fix Android favourite handling when creating contact When processing PersonaDetail.GROUPS before PersonaDetail.IS_FAVOURITE while creating a new contact in EDS, the special code for adding the contact to the “Starred in Android” group (bgo#661490 was skipped). We must go through _set_is_favourite instead of _set_contact_is_favourite to get that part done, too. NEWS | 2 ++ backends/eds/lib/edsf-persona-store.vala | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) commit 6aaded38f044d6dc2bb28db020bcdaff32e09c76 Author: Patrick Ohly Date: Thu Feb 7 15:28:08 2013 +0100 eds: support 'groups' when creating a contact There's a minor twist with supporting the setting of groups from details: _set_contact_groups() needs to know whether the contact is a favorite, for special handling of Google contacts. If the PersonaDetail.IS_FAVOURITE is found first in the details, that boolean is passed to a later _set_contact_groups(). If _set_contact_groups() is done first, then _set_contact_is_favourite() applies the special Google workaround. backends/eds/lib/edsf-persona-store.vala | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) commit 4a59bc621d55a09718355b46c73f9c71d1f8f90f Author: Travis Reitter Date: Sun Feb 17 19:53:40 2013 -0800 Update the home page listed in DOAP file folks.doap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c72e47f21a56b00e29cfefbb90bedfb0d3e0e133 Author: Travis Reitter Date: Sun Feb 17 19:44:29 2013 -0800 Post-release version bump NEWS | 11 +++++++++++ configure.ac | 4 ++-- 2 files changed, 13 insertions(+), 2 deletions(-)